Skip to content

The min and max range value disappears when reached at a certain point. #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dassaptorshi opened this issue Aug 17, 2016 · 15 comments
Closed

Comments

@dassaptorshi
Copy link
Contributor

Steps to reproduce

  1. Say the ciel value is 100
  2. When we start sliding towards it around 90 or 91 the label disappears.
  3. Both for min and max

Expected behaviour

There should be a config which can be done to keep the label even when it reaches the limit.

Actual behaviour

It hides the label.We have an option 'hideLimitLabels' however it hides the limit label completely.
We have a function 'updateHighHandle' which calls this.shFloorCeil() which I believe add the visibility hidden to the CSS. If this can be configured it will be nice.not to call the function.

@ValentinH
Copy link
Member

So you want this kind of result?
image

@dassaptorshi
Copy link
Contributor Author

dassaptorshi commented Aug 17, 2016

slider
When we drag it around say 80 the label disappears.same goes for the min side label when we drag it around 30. Hope this helps

@ValentinH
Copy link
Member

I don't understand what you need

@dassaptorshi
Copy link
Contributor Author

say i want to drag the slider towards the max value which is 100 , at a certain point, the label max $100 disappears (say at $80) however I would like the label to stay even if I have reached the limit.

@ValentinH
Copy link
Member

So like on my screenshot?

@dassaptorshi
Copy link
Contributor Author

dassaptorshi commented Aug 17, 2016

Yes.
slidernew
slidernew

I wont like the label to be hidden ever.

@dassaptorshi
Copy link
Contributor Author

i the directive we have a function updateHighHandle' which calls this.shFloorCeil() which I believe add the visibility hidden to the CSS. So if there is a way we can configure it.

@dassaptorshi
Copy link
Contributor Author

https://jsfiddle.net/saptorshiDas/87ydqyww/

When I drag the slider above say 95 the label disappers. Please kindly check.

@ValentinH
Copy link
Member

What I'm asking is that if the result I shown in my first screenshot is what you expect?

@dassaptorshi
Copy link
Contributor Author

Yes!

@ValentinH
Copy link
Member

OK! Then I'll add an option to disable this auto hiding behavior. But are you sure of it, because in my opinion, it looks weird to have overlapped labels

@dassaptorshi
Copy link
Contributor Author

yup that should help. If i need any more help i will get back to you. Thanks a ton!!

@dassaptorshi
Copy link
Contributor Author

dassaptorshi commented Aug 17, 2016

Valentin, When can please provide me with the time you might need to make this change as its urgent.Thanks

@ValentinH
Copy link
Member

If it's urgent, you should do it yourself and contribute a pull request! ;)

@ValentinH
Copy link
Member

Implemented in #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants