Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ticks-values positioning by using bottom instead of top #464

Open
ValentinH opened this issue Nov 22, 2016 · 13 comments
Open

Change ticks-values positioning by using bottom instead of top #464

ValentinH opened this issue Nov 22, 2016 · 13 comments

Comments

@ValentinH
Copy link
Member

ValentinH commented Nov 22, 2016

Currently, top: Xpx is used for horizontal sliders, but it would be better to use bottom so the alignement remains the same for different font sizes.

@ValentinH ValentinH self-assigned this Nov 22, 2016
@upeshdesai
Copy link

also interested in this

@Kashyap12
Copy link

Hi can I take this up @ValentinH ?

@ValentinH
Copy link
Member Author

Sure! Do you know from where to start?

@Kashyap12
Copy link

No , I am quite new to OS projetcs

@ValentinH
Copy link
Member Author

For this issue, you only need to update the rzslider.less file. Before starting, you should read the CONTRIBUTING.md one.

@ValentinH
Copy link
Member Author

The goal is to get the exact same rendering than the current version. So while developing the change, you should compare with the demo website: http://angular-slider.github.io/angularjs-slider/

@Kashyap12
Copy link

ok , thanks @ValentinH , will start now

@ValentinH
Copy link
Member Author

Then to display your changes, you need to open the demo/index.html file in a browser.

@ValentinH
Copy link
Member Author

Finally, when submitting the pull request, please provide a JSFiddle running your fork version that show that everything works.

You can fork this one: http://jsfiddle.net/cwhgLcjv/ and update the library import:

<script src="https://rawgit.com/rzajac/angularjs-slider/master/dist/rzslider.js"></script>

by replacing rzajac by your username.

@ValentinH
Copy link
Member Author

Basically like it was done in #505

@Kashyap12
Copy link

Cool @ValentinH

@karolinanovaksolanska
Copy link

Hello @ValentinH,
I see this issue is still open, can I take it up?

@ValentinH
Copy link
Member Author

Yes sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants