-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ticks-values positioning by using bottom instead of top #464
Comments
also interested in this |
Hi can I take this up @ValentinH ? |
Sure! Do you know from where to start? |
No , I am quite new to OS projetcs |
For this issue, you only need to update the rzslider.less file. Before starting, you should read the CONTRIBUTING.md one. |
The goal is to get the exact same rendering than the current version. So while developing the change, you should compare with the demo website: http://angular-slider.github.io/angularjs-slider/ |
ok , thanks @ValentinH , will start now |
Then to display your changes, you need to open the |
Finally, when submitting the pull request, please provide a JSFiddle running your fork version that show that everything works. You can fork this one: http://jsfiddle.net/cwhgLcjv/ and update the library import: <script src="https://rawgit.com/rzajac/angularjs-slider/master/dist/rzslider.js"></script> by replacing |
Basically like it was done in #505 |
Cool @ValentinH |
Hello @ValentinH, |
Yes sure :) |
Currently,
top: Xpx
is used for horizontal sliders, but it would be better to usebottom
so the alignement remains the same for different font sizes.The text was updated successfully, but these errors were encountered: