Skip to content

ghj #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
souravkole opened this issue May 12, 2017 · 6 comments
Closed

ghj #530

souravkole opened this issue May 12, 2017 · 6 comments

Comments

@souravkole
Copy link

souravkole commented May 12, 2017

Steps to reproduce

  1. Open the Demo Link provided below
  2. Scroll down at "Range slider with ticks and values at intermediate positions"
  3. Showing step numbers in different position in IE browser(11).

Demo: http://angular-slider.github.io/angularjs-slider/

Expected behaviour

Step numbers should appear below the scale, as displayed in Chrome

image

Actual behaviour

Step numbers are appearing on top of the scale, step number and selected step numbers are overlapping,
So it is not working properly in Internet Explorer

image

@ValentinH
Copy link
Member

Indeed, this is a bug. Unfortunately, I don't have a Windows machine to try this on...
The issue might be to the following rule that could be broken on IE:

.rzslider .rz-ticks-values-under .rz-tick-value {
    top: initial;
    bottom: -32px;
}

Could you try to inspect to css rules in IE11 to see if there is a warning?

@ValentinH ValentinH added the bug label May 12, 2017
@ValentinH
Copy link
Member

Indeed, it must be due to initial not being supported in IE: https://www.w3schools.com/cssref/tryit.asp?filename=trycss_initial

@ValentinH
Copy link
Member

The fix seems to replace initial by auto, but it requires more checks to ensure it's fine on the other browsers. Would you like to submit a pull request for this?

@nrgwsth
Copy link
Contributor

nrgwsth commented May 13, 2017

Can I work on this issue?

@ValentinH
Copy link
Member

Sure ;)

@ValentinH
Copy link
Member

Fix released under 6.1.2 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants