Skip to content

Adds labelOverlapSeparator option to customize default ' - ' #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BenLayet opened this issue Feb 4, 2018 · 5 comments
Closed

Adds labelOverlapSeparator option to customize default ' - ' #615

BenLayet opened this issue Feb 4, 2018 · 5 comments

Comments

@BenLayet
Copy link

BenLayet commented Feb 4, 2018

When the range labels overlap the separator string is ' - '.
The problem is that this character can be interpreted as 'minus'.

Steps to reproduce

  1. slider range with high value just above 0
    http://jsfiddle.net/04sr3ty0/1/

Expected behaviour

Should be able to tell if the high value is positive of negative

Actual behaviour

Looks like the range is -2 to -1 when in fact it is -2 to +1

I am happy to create a pull request to fix this minor issue

@ValentinH
Copy link
Member

Hi @ben-henoida ,

I've never thought about this, but this makes sense! ^^

What character should we use in your opinion?

@BenLayet
Copy link
Author

BenLayet commented Feb 4, 2018

' .. ' is common enough to represent range : -2 .. 1
How about a making it an option ?

@ValentinH
Copy link
Member

Yes let's make it an option and keep the default to be - so we don't make a breaking change. 👍 If you can make a PR for this, it would be awesome! ;)

@BenLayet
Copy link
Author

BenLayet commented Feb 6, 2018

PR created : #616

@ValentinH
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants