Skip to content

feat(logScale): Implement a logScale option #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2016
Merged

feat(logScale): Implement a logScale option #280

merged 3 commits into from
Oct 16, 2016

Conversation

ValentinH
Copy link
Member

@ValentinH ValentinH commented Feb 25, 2016

Implement a logScale option to display sliders with logarithmic scale.
Demo: http://jsfiddle.net/v6spvvpg/

Todo:

  • handle ticks

@codecov-io
Copy link

codecov-io commented Feb 25, 2016

Current coverage is 100% (diff: 100%)

Merging #280 into master will not change coverage

@@           master   #280   diff @@
====================================
  Files           1      1          
  Lines         869    896    +27   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          869    896    +27   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 37a4f90...7328dc6

@BrunoCartier
Copy link

This would be a useful feature 👍

@ValentinH
Copy link
Member Author

I could merge it but it won't support ticks cause I couldn't find a way to display them correctly.

@sebnyc
Copy link

sebnyc commented Oct 4, 2016

Hi Valentin,
Greetings from a French expatriate from NYC.
Would you consider merging this pull request (even without ticks) ? I would definitely use it if it was made available.
Sébastien

@ValentinH
Copy link
Member Author

OK I'll merge it. Just need to add tests then. ;)

@ValentinH
Copy link
Member Author

This was merged and released under 5.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants