fix(applyPushRange): Apply the pushRange with maxRange #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the pushRange when the difference is greater than the maxRange set Close issue angular-slider#453
Current coverage is 100% (diff: 100%)@@ master #456 diff @@
====================================
Files 1 1
Lines 912 921 +9
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 912 921 +9
Misses 0 0
Partials 0 0
|
|
Thanks for this PR, it is just perfect! It feels good to have such a nice contribution with tests and everything ;) Actually your solution is better than the one I suggested in the issue because mine would have just blocked the slider when maxRange would be reached while your "pull" behavior is neat! |
|
Released under 5.8.6 |
|
Thank you ! Glad to help… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the pushRange when the difference is greater than the maxRange set
Close issue #453
Fixed demo: http://jsfiddle.net/nx7yqqa5