-
-
Notifications
You must be signed in to change notification settings - Fork 496
Feature/restricted range #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/restricted range #583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 950 970 +20
=====================================
+ Hits 950 970 +20
Continue to review full report at Codecov.
|
Hi, thanks for this pull request! |
We updated the demo with a restricted range slider as well, so checkout should also work. Here's a fiddle: https://jsfiddle.net/2hxm9cop/1/ |
Thanks for the compliment (and the work maintaining this project!). Cool gif! That's a clever way to communicate these things. For us this is intended behaviour because in our use case we wish to discourage moving from one side to the other. It could be an option, like |
For the GIF, I use this really nice tool: https://getkap.co About the option, I don't really know how to approach this. I think the middle thing should be the default and we should add an option to address your use case. Do you have an idea of how we could design this option? |
I've decided it's best to not overdesign this, and have changed it to switch in the middle instead. Extra checks can be done by consumers of the slider's model values anyway. |
@ValentinH is there anything else you would like changed about this? We're currently thinking about allowing more than one restricted range, but that's probably best as a separate PR once this one's complete. |
Hey, It's been a long time! ^^ Just tried your last fiddle and it looks fine. Could you rebase your changes on top of master so I can review it? Thanks by advance! |
Hi, I made a new branch/PR as per request (#638) |
Hi, we added a restricted range because we needed one, and this slider seemed the best starting point.