Skip to content

fix(options): react to changes of options of Function type #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

zuzusik
Copy link
Contributor

@zuzusik zuzusik commented Nov 14, 2017

fixes #589

@codecov-io
Copy link

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #590   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         950    950           
=====================================
  Hits          950    950
Impacted Files Coverage Δ
src/rzslider.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e69b0...73ca0b9. Read the comment docs.

@ivanvoznyakovsky
Copy link

great find 💯

@ValentinH
Copy link
Member

Good stuff!

@ValentinH ValentinH merged commit de7ecef into angular-slider:master Nov 17, 2017
@ValentinH
Copy link
Member

Released under 6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing options of Function type in runtime is not supported
4 participants