Skip to content

Conversation

@joshrickert
Copy link

Very minor, but I assume there was a typo here. A conditional on

delta <= 0 && delta < 1

makes no sense, because the second statement definitely false if the first is. It seems like you meant to check if the delta was between 0 and 1.

I assume this was a typo, as the logic made no sense as written.
@ValentinH
Copy link
Member

I guess you're right because it doesn't make sense. However, this code is linked with #74 and we need to find a solution.

Actually, delta < 1 is enough because delta comes from Math.abs() so it's obviously above 0

@ValentinH ValentinH closed this in f2d86de Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants