issue 960, 772, 946 ChildModel, clonedModel #961
Conversation
| @@ -21,7 +21,7 @@ | |||
| <link href="//netdna.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap.min.css" rel="stylesheet"/> | |||
| <link href='//fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,700italic,800italic,400,800,600,300,700' | |||
| rel='stylesheet' type='text/css'> | |||
| <link href="//rawgit.com/angular-ui/angular-google-maps/master/example/assets/stylesheets/example.css" rel="stylesheet" type="text/css"> | |||
| <link href="./assets/stylesheets/example.css" rel="stylesheet" type="text/css"> | |||
There was a problem hiding this comment.
not sure if these urls will work for the (website) demo.. lets find out
- This is ripe for a ChildBase Class This makes angular-ui#946 and angular-ui#772 compatible
| @@ -2413,6 +2413,7 @@ Nicholas McCready - https://twitter.com/nmccready | |||
| this.defaults = defaults; | |||
| this.model = model; | |||
| this.clean = __bind(this.clean, this); | |||
| this.clonedModel = _.clone(this.model, true); | |||
There was a problem hiding this comment.
@cthrax since you just looked at his code recently. Remember the _.clone stuff being passed in? Well it is ideal to have clones for comparison. However it sucks when we pass the models back to the Controllers (through behaviors and functions). IE if we don't pass reference back to the Controller the user can't make changes in the model to be reflected back to the directive. This is why #772 broke and how this keeps #946 happy.
| @@ -22,7 +22,7 @@ angular.module('uiGmapgoogle-maps.directives.api.utils') | |||
|
|
|||
| wrapped.promise | |||
|
|
|||
| onlyTheLast = (-> | |||
| onlyTheLast = do -> | |||
nmccready
force-pushed
the
nick_mc/issue_960
branch
from
7948b99 to
9019c74
Compare
of windows (when dependent on markers) watching models we watch a simple change counter. The change counter indicates that Markers is done doing work, and then Windows can proceede to do its processing. This way a gMarker is sure to be available without a race of windows to markers. build all typo on WindowChild constructor usage in it's parent model typos on scope.existingPieces build all
| @@ -183,6 +187,7 @@ angular.module("uiGmapgoogle-maps.directives.api.models.parent") | |||
| delete @scope.markerModels | |||
| @gMarkerManager.clear() if @gMarkerManager? | |||
| @scope.markerModels = new PropMap() | |||
| @scope.markerModelsUpdate.updateCtr += 1 | |||
There was a problem hiding this comment.
all @scope.markerModelsUpdate.updateCtr += 1 are in the final .then of each promise and in the Destruction / Cleanup
|
looks great |
| @gWin.open @mapCtrl, maybeMarker | ||
| isOpen = @gWin.isOpen() | ||
| # @scope.$evalAsync => | ||
| # ChromeFixes.maybeRepaint @gWin.content |
There was a problem hiding this comment.
okay, so we still are going to have to figure out how to get the tail/x to show up consistently
There was a problem hiding this comment.
It seems to be working fine. I haven't seen it happen yet.
issue 960, 772, 946 ChildModel, clonedModel
@aesnyder
@zacronos
Commits deal with 2 issues