Add carousel indicators

[pkozlowski-opensource]

There was a new release of Bootstrap's CSS and I guess that updating things should be fairly painless.

The only change that I can immediately see is that carousel got nice indicators. There are probably other changes, for example the container option for tooltips and popovers, but we are discussing this in a separate issue.

Complete changelog here: https://github.com/twitter/bootstrap/blob/master/CHANGELOG.md

In short - the update should be straightforward. Didn't look at the markup for carousel indicators but I can't see reason for this to be complicated to add.

[pkozlowski-opensource]

I've bumped up Bootstrap's version in 9a867a2

Had also a quick look at the carousel as I've hoped that it will be enough to change a template but in the end it looks like we need to expose more on the scope of the carousel directive. Shouldn't be a big deal since this is an isolated scope but I was wondering if we should be exposing slide's scopes or maybe just length of slides array and base everything on indexes.

@ajoslin could you please have a look at my louse experiments in https://github.com/angular-ui/bootstrap/tree/carousel_indicators before I commit to this direction and add tests?

[petebacondarwin]

Looks OK to me.

On 16 February 2013 20:28, Pawel Kozlowski notifications@github.com wrote:

I've bumped up Bootstrap's version in 9a867a29a867a2

Had also a quick look at the carousel as I've hoped that it will be enough
to change a template but in the end it looks like we need to expose more on
the scope of the carousel directive. Shouldn't be a big deal since this is
an isolated scope but I was wondering if we should be exposing slide's
scopes or maybe just length of slides array and base everything on indexes.

@ajoslin https://github.com/ajoslin could you please have a look at my
louse experiments in
https://github.com/angular-ui/bootstrap/tree/carousel_indicators before I
commit to this direction and add tests?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/145#issuecomment-13674208.