You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
Currently, the select callback of a clicked tab fires before the deselect of the currently active tab. To me, the more natural order would be the reverse. That way it would be easier to figure out where to put code that should run some cleanup in the tab that being deselected (which, if deselect and select callbacks modify the same global variable, it kindof a big deal).
In my use case, selecting one tab causes a sidebar to be shown, deselecting it causes it to hide. If I have two tabs with that behavior, the select event of the clicked tab will fire, causing the already open sidebar to open, then the deselect event fires, causing it to close.
I wouldn't be opposed to writing up a patch if you agree with my take on things.
The text was updated successfully, but these errors were encountered:
Currently, the select callback of a clicked tab fires before the deselect of the currently active tab. To me, the more natural order would be the reverse. That way it would be easier to figure out where to put code that should run some cleanup in the tab that being deselected (which, if deselect and select callbacks modify the same global variable, it kindof a big deal).
In my use case, selecting one tab causes a sidebar to be shown, deselecting it causes it to hide. If I have two tabs with that behavior, the select event of the clicked tab will fire, causing the already open sidebar to open, then the deselect event fires, causing it to close.
I wouldn't be opposed to writing up a patch if you agree with my take on things.
The text was updated successfully, but these errors were encountered: