bug(modal) - modal scope is not destroyed on close

[Halama]

Hi,
since version 0.10.0 modal $scope isn't destroy on modal close.
There are examples of this behaviour, please open browser console while testing.

Example using 0.10.0 (There is a bug):
http://plnkr.co/edit/luXIk8fRD3RaRYvFXUCA?p=preview

Example using 0.9.0 (Works fine):
http://plnkr.co/edit/qLAcaEcGryXOhBXoKp6v?p=preview

thanks

[Foxandxss]

You're right. I need to research more on it. @pkozlowski-opensource thoughts?

[pkozlowski-opensource]

yup, this is a bug, side-effect of supporting close animations. Pretty easy fix, tests are not so obvious to write :-)

[chrisirhc]

Interesting, I must've introduced it. Need to account for this when using nganimate.

[pkozlowski-opensource]

@chrisirhc I will push a quick fix in a sec but yes, $animate will be a proper solution

[chrisirhc]

Cool thanks! Yep I'll look into it.

[asapach]

Guys, that's a pretty critical bug. Could you please backport the fix to the 0.10 branch/tag if 0.11 is too far away.

[gazsp]

Is there any news on this for v0.10?

Ignore me. Just patched my source for now.

[JasonRodman]

Any idea when this will be fixed?

[asapach]

I believe it's already fixed in 0.11: http://plnkr.co/edit/iuaRN1L07ojBbqyMyIpx?p=preview

[JasonRodman]

I just upgraded to 0.11 and the event still does not fire.

[JasonRodman]

For some unexplained reason it just started working. Cant figure out why.

[aymericbeaumet]

Hey Pawel,

I still encounter this issue in both 0.10 and 0.11. Has this been fixed in the latest stable version?

[segevofer]

Hey Pawel,
me too! any news about this bug?

[spotlmnop]

Same here, I can still see this bug.

[neoblackcap]

I use the 0.11 version, and the event can be triggered. I think this bug has been fixed.

[spotlmnop]

Yes, 0.11 fixes this issue. If someone here is working 1.3.0 angular , the only supported version is 1.3.0-beta.10. Else, typeahead does not work. Hope this helps someone.

[ribbitfix]

I was having this issue on 0.11, but figured out that I was calling .close() twice.

[DmitryEfimenko]

I still experience the issue.
Running:
angular v1.3.0-beta.11
angular-ui-bootstrap v0.11.0

[chrisirhc]

@karianna , let's not be hasty to reopen this. #3308 doesn't explain what's broken and doesn't have a reproduction.

[citosid]

@chrisirhc did you find any solution?

[DannyFeliz]

I can't believe that this bug still messing around at this time. 👎

[AndrewIsh]

I am experiencing this with v1.3.3. Would it be possible to re-open this issue, as far as I can see it is unresolved.

[barne397]

@AndrewIsh, I was just posting that I'm also having issues with v1.3.3, but turns out I had failed to account for an isolate scope on the directive where I was listing for the destroy event. So, I was listening to the wrong scope. It was getting destroyed, I just wasn't seeing the event.

Just wanted to mention that in case you're doing something similar.

[amonsot890]

any clear solutions on this .?