Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Switch to Grunt 0.4.x #207

Closed
pkozlowski-opensource opened this issue Mar 9, 2013 · 6 comments
Closed

Switch to Grunt 0.4.x #207

pkozlowski-opensource opened this issue Mar 9, 2013 · 6 comments

Comments

@pkozlowski-opensource
Copy link
Member

Currently Jenkins CI build is failing (http://ci.angularjs.org/job/angularui-bootstrap/249/console) as the grunt command points to the grunt-cli now and it expects Grunt 0.4. We could try to install Grunt 0.3.x locally but we need to migrate anyway.

@petebacondarwin
Copy link
Member

Locally is easy enough. Just add it to the package.json

On 9 March 2013 12:21, Pawel Kozlowski notifications@github.com wrote:

Currently Jenkins CI build is failing (
http://ci.angularjs.org/job/angularui-bootstrap/249/console) as the gruntcommand points to the
grunt-cli now and it expects Grunt 0.4. We could try to install Grunt
0.3.x locally but we need to migrate anyway.


Reply to this email directly or view it on GitHubhttps://github.com//issues/207
.

@pkozlowski-opensource
Copy link
Member Author

It is part of the package.json but the main issue is that Jenkins-CI won't pick it up. We could probably talk to Igor but IMO it is beneficial to switch anyway.

@petebacondarwin based on your work for angular-app, is it hard to migrate? I mean, any special / quirky bits to be aware of?

@pkozlowski-opensource
Copy link
Member Author

OK, so it looks like I was wrong - simply migrating to Grunt 0.4 won't change anything.

What is going on (or at least this is my understanding) is that now the grunt command on Jenkins-CI refers to the Grunt-CLI and it requires grunt to be installed locally: https://github.com/gruntjs/grunt/wiki/Upgrading-from-0.3-to-0.4

So we need to ask Igor to change script that runs the build to include npm install step

@petebacondarwin
Copy link
Member

How is the core angular.js repos doing it now? They are using grunt-cli and
grunt-0.4.0

On 9 March 2013 20:59, Pawel Kozlowski notifications@github.com wrote:

OK, so it looks like I was wrong - simply migrating to Grunt 0.4 won't
change anything.

What is going on (or at least this is my understanding) is that now the
grunt command on Jenkins-CI refers to the Grunt-CLI and it requires grunt
to be installed locally:
https://github.com/gruntjs/grunt/wiki/Upgrading-from-0.3-to-0.4

So we need to ask Igor to change script that runs the build to include npm
install step


Reply to this email directly or view it on GitHubhttps://github.com//issues/207#issuecomment-14670534
.

@pkozlowski-opensource
Copy link
Member Author

So what done in AngularJS is that build script calls npm install, exactly like Travis-CI scripts. This will install all the dependent modules locally.

We were discussing this with Igor already and he was a bit uneasy with the idea of installing anything so we might need to list all the npm modules in the build script. This is a bit unfortunate since it will duplicate entries from package.json. To be discussed.

I've opened #211 with the first-shoot switch to Grunt 0.4.x.

@pkozlowski-opensource
Copy link
Member Author

Switched in 98b5f8e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants