Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Tooltip/popover placement is off in input-groups with 0.12.0 #2995

Closed
somelinguist opened this issue Nov 19, 2014 · 3 comments
Closed

Tooltip/popover placement is off in input-groups with 0.12.0 #2995

somelinguist opened this issue Nov 19, 2014 · 3 comments

Comments

@somelinguist
Copy link

Tooltip/popover placement is off in input-groups with 0.12.0. In the following example, the tooltip is attached to the top-right corner instead of the left side.

http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

<form role="form">
  <div class="form-group small">
      <div class="input-group">
          <input type="text" class="form-control input-sm">
          <span class="input-group-btn">
              <button class="btn btn-sm btn-default"><i class="fa fa-folder-open"></i></button>
              <button class="btn btn-sm btn-default" tooltip-placement="left" tooltip="Push again to stop recording." tooltip-append-to-body="true"><i class="fa fa-circle"></i></button>
          </span>
      </div>
  </div>
</form>

Bootstrap 3.3.1
Angular 1.3.0

Using other versions of Angular or Bootstrap doesn't seem to make a difference.

However, it works fine in ui-bootstrap 0.11.2.

@chrisirhc
Copy link
Contributor

Thank you for the excellent reporting! Including a Plunker and the Angular and Bootstrap versions you've tested was very helpful in narrowing this down. I've found the issue.
Note to myself to check if the fix for this will fix #2992

@chrisirhc chrisirhc self-assigned this Nov 19, 2014
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 19, 2014
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in angular-ui#2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

Fixes angular-ui#2995

Correctly fixes angular-ui#2951 without removing $digest.
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 19, 2014
The $digest that was removed in 32c470 is actually necessary to get the
tooltip contents rendered. The rendered content is important when the
tooltip is on the right edge. See Plunker in angular-ui#2995:
http://plnkr.co/edit/8GZ5F5zj3Xe6IinXQz74?p=preview

Reverts change in 32c470 (angular-ui#2995) but fixes it in another way.

Fixes angular-ui#2995
Fixes angular-ui#2992
Fixes angular-ui#2951
Closes angular-ui#2996
@somelinguist
Copy link
Author

Thanks for the quick response. I'm glad you could track it down.

@egeland
Copy link

egeland commented Nov 24, 2014

This is why I love open source - I had this same issue and searched the issues and lo and behold, it's already fixed in the soon-to-come release! :)
Thank you @somelinguist for reporting it and @chrisirhc for the fix - looking forward to seeing it released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants