error on typeahead

[Tallyb]

in the last line (in getMatchesAsync):
var onCurrentRequest = (inputValue === modelCtrl.$viewValue);
if (onCurrentRequest && hasFocus) {
if (matches.length > 0) {
an error is thrown that matches.length is not defined.
on the next attempt - it works ok.

[pkozlowski-opensource]

https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md#you-think-youve-found-a-bug

[Tallyb]

http://plnkr.co/edit/4hC1F6dKfGS3rRXqLtiN?p=preview
ui bootstrap version is 0.12. The plunker uses angular 1.2.x, in my code I use .1.3.3 (happens the same)
In addition restangular and lodash are used (versions in plunker).
start typing "aa" in the input box, and check the console (only happens on the first time.
fix is either defining $scope.matches or checking if $scope.matches is undefined.
Please let me know if anyting else is required.

[unkleara]

I had this error as well using another library to help with with fuzzy search. I needed to make a copy of the array from the response and have the other library work on new array and return those values to typeahead. The typeahead function that checks $viewValue isn't dealing with the original array after a certain point, so "matches" becomes undefined and if the results are empty it can't reference the original array to check the length property.

A quick fix was to just check if matches are defined and then the length.

if (matches && matches.length > 0) 

Following is where I made the change in case it will help someone in the future.
https://github.com/angular-ui/bootstrap/blob/master/src/typeahead/typeahead.js#L134

[antoinepairet]

It does not happen every time. I have the feeling there is a issue of timing. Using your plunkr, if I quickly use the typeahead the error will show up. If I wait long enough, the error will not happen.

That being said, the fix seems obvious and harmless. thanks @unkleara

[rkriitr]

if (matches && matches.length > 0) prevents the undefined error, but first time, the matched dropdown does not show up anyway. Please tell me what needs to be done. As above indicated, from second time onwards, everything works fine.

[rkriitr]

sorry, in the code

                   <input ng-model="brandChainName"
        typeahead="name for name in brandChainNames | filter:$viewValue | limitTo:8"
        typeahead-template-url="columnTwo.html" >

brandChainNames was not intialized. Now it is working. It is not a bug in bootstrap, it is bug on the coder's part.