$dialog, modal and location change

[pkozlowski-opensource]

Created based on angular-ui/angular-ui-OLDREPO#538 from the angular-ui repo:

I have run into an issue with Modals and Dialogs when a browsers back button is pressed while a modal and glassis visible. (in a multi page app).

The application changes the view and controller while the modal stays activated and visible. As the controller has been swapped out from underneath the modal, strange things start happening.

How do we get around this issue? Is there a way to make sure the modal / dialog is dismissed when the back button is dismissed or the route is changed.

It is an interesting problem, we should consider closing modals on location change. The thing that the modal stays open while controllers can be sapped underneath sounds like a buggy situation.

[Monish-Parajuli]

I am facing this issue, here is a plunker for it http://plnkr.co/MhYssd1GiOx1d1YwOyf0. I am currently working around it by exposing the dialog in rootScope and I checking for it in the controllers/binding to route change. It is very hacky, I hope there is a better way.

[pkozlowski-opensource]

@mxparajuli Wow, awesome plunk :-) I wish all the bug reports were like this!

We should definitively fix this in the $dialog service, probably by listening to $locationChangeSuccess.

@mxparajuli Would you be up to sending a pull request for this? It should be pretty straightforward.

[Monish-Parajuli]

@pkozlowski-opensource Sure thing! I'll send a pull request soon. My first pull request :)

[sudhakar]

Right now $dialog creates a new scope from $rootScope. Cant we have it to have a childscope from the current view. So then theoretically when the parent view is destroyed, $dialog will take care of itself.

I know it has been discussed before, but just thinking out loud 🔢

[sudhakar]

Or may be we can provide an additional option like destroyWith to the $dialog service and allow the user to pass the current scope. Then in the $dialog service, we can watch for $destroy event of that local scope and then destroy the $dialog scope.

But this will necessitate user to explicitly specify it..

[Monish-Parajuli]

@sudhakar I like the idea of $dialog having a child scope of the current view. How do you suggest $dialog be passed the view's childscope? I am new to angular but I am learning and I want to help :)

[sudhakar]

$dialog service is usually invoked inside a view controller. By design, $dialog/model itself requires another controller, which needs to be explicitly defined by the user. This controller gets a new scope using $rootScope.$new.

This is byDesign. Checkout more discussion on this @ #259

After giving it a thought, I think we might need to combine both destroyWith with $routeChangeSuccess. So that if user doesnot explicitly specify destroyWith, $routeChangeSuccess event can be used to destroy the dialog..

@pkozlowski-opensource is the right person to comment on this...

[Monish-Parajuli]

I've been occupied with other stuff but I have submitted a pull request that watches location change. I like @sudhakar 's suggestions but I will read up a bit more before trying anything.

@sudhakar thanks for the link to the discussion.