Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

popover-placement not respected when using popover-template #3473

Closed
trendzetter opened this issue Mar 30, 2015 · 3 comments
Closed

popover-placement not respected when using popover-template #3473

trendzetter opened this issue Mar 30, 2015 · 3 comments
Assignees
@chrisirhc
Labels
component: popover type: bug
Milestone
0.13.0 (AngularJS...

Comments

@trendzetter
Copy link

When using the new popover template the placement is always default.
I am using this branch:
https://github.com/chrisirhc/angular-ui-bootstrap/tree/feature/popover-template
@chrisirhc
Copy link
Contributor

Please create a Plunker to demonstrate your issue.

Note that you should be using the popover-template-placement attribute.

@trendzetter
Copy link
Author

My mistake. It works with popover-template-placement. I was trying with popover-placement.

@chrisirhc chrisirhc reopened this Apr 6, 2015
@chrisirhc chrisirhc added this to the 0.13.0 milestone Apr 6, 2015
@chrisirhc
Copy link
Contributor

Actually, this is my mistake, heh. It shouldn't be reading from popover-template-placement. It should be set as popover-placement. I'll fix that.

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 6, 2015
@chrisirhc
fix(tooltip): use correct prefix for -template
125d718 
Fixes angular-ui#3473
@chrisirhc chrisirhc mentioned this issue Apr 6, 2015
Closed
@chrisirhc chrisirhc self-assigned this Apr 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisirhc chrisirhc

Labels
component: popover type: bug
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

Successfully merging a pull request may close this issue.

fix(tooltip): use correct prefix for -template chrisirhc/angular-ui-bootstrap
3 participants
@chrisirhc @karianna @trendzetter