Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Change popover/tooltip-template to evaluate expression #3558

Closed
chrisirhc opened this issue Apr 17, 2015 · 0 comments
Closed

Change popover/tooltip-template to evaluate expression #3558

chrisirhc opened this issue Apr 17, 2015 · 0 comments

Comments

@chrisirhc
Copy link
Contributor

Must do this before 0.13.0 release, as it would be a breaking change if we do this after release.
Before:

popover-template="template.html"

After

popover-template="'template.html'"

The reason for this is to support $sce trusted urls. In order to pass a trusted URL, one needs to use an expression.

In JS:
$scope.templateUrl = $sce.trustAsResourceUrl('http://good.com/template.html');

In HTML:
popover="templateUrl"
@chrisirhc chrisirhc added this to the 0.13.0 (AngularJS 1.3) milestone Apr 17, 2015
@chrisirhc chrisirhc self-assigned this Apr 17, 2015
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 19, 2015
Allows for trusted resource URLs through Strict Contextual Escaping ($sce).
If the an interpolated expression is used instead, then the benefits of SCE is
lost.

Fixes angular-ui#3558
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 19, 2015
Allows for trusted resource URLs through Strict Contextual Escaping ($sce).
If the an interpolated expression is used instead, then the benefits of SCE is
lost.

Fixes angular-ui#3558
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 20, 2015
Allows for trusted resource URLs through Strict Contextual Escaping ($sce).
If the an interpolated expression is used instead, then the benefits of SCE is
lost.

Fixes angular-ui#3558
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 20, 2015
Allows for trusted resource URLs through Strict Contextual Escaping ($sce).
If the an interpolated expression is used instead, then the benefits of SCE is
lost.

Fixes angular-ui#3558
chrisirhc added a commit that referenced this issue Apr 29, 2015
Allows for trusted resource URLs through Strict Contextual Escaping ($sce).
If an interpolated expression is used instead, then the benefits of SCE is
lost.

Fixes #3558
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant