Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Cant use ng-class on accordion group since 1.33.3 #4193

Closed
blowsie opened this issue Aug 12, 2015 · 5 comments
Closed

Cant use ng-class on accordion group since 1.33.3 #4193

blowsie opened this issue Aug 12, 2015 · 5 comments

Comments

@blowsie
Copy link

blowsie commented Aug 12, 2015

You can no longer use ng-class on an accordion group since this commit.

ead15e37

#4152
#3419

@blowsie blowsie changed the title Cant use ng-class on accordion group since 1.3.3 Cant use ng-class on accordion group since 1.33.3 Aug 12, 2015
@blowsie
Copy link
Author

blowsie commented Aug 12, 2015

Saldy, I'm closing this due to the responses on here
#4172


Sadface.

@blowsie blowsie closed this as completed Aug 12, 2015
@icfantv
Copy link
Contributor

icfantv commented Aug 12, 2015

Don't be sad. We're actually looking out for you and your app's best interests here (even though it may not feel like it). Did you read the comments in this link? Merging classes can yield very unpredictable behavior - this is one of the reasons replace: true can be so evil.

davious added a commit to davious/angular-ui-bootstrap that referenced this issue Aug 13, 2015
@LeleDev
Copy link

LeleDev commented Aug 17, 2015

Temporary workaround - put your ng-classes in your plain "class" attribute:

Before:

ng-class="{'expanded': status.open}"

After:

class="{{status.open ? 'expanded':''}}"

@icfantv
Copy link
Contributor

icfantv commented Aug 17, 2015

@LeleDev, this is not a workaround, temporary or otherwise. CSS classes are not applied in the order they appear in your DOM element's class attribute, but rather, where they are defined in your CSS file(s), and thus, the order in which they are loaded.

@LeleDev
Copy link

LeleDev commented Aug 17, 2015

It's a workaround for who wants to make things works without using ng-class, and it should work in most of the cases

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants