Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Timepicker - expose template url #4275

Closed
waratah opened this issue Aug 26, 2015 · 4 comments
Closed

Timepicker - expose template url #4275

waratah opened this issue Aug 26, 2015 · 4 comments

Comments

@waratah
Copy link

waratah commented Aug 26, 2015

I have a need to override the formatting of the time picker and note the documentation does not include the ability to use a template url attribute which would be consistent with other components.

This would allow me to move the spinners around to best fit the screens.

@wesleycho wesleycho added this to the 0.13.4 (Performance) milestone Aug 26, 2015
@wesleycho
Copy link
Contributor

Currently that feature is not implemented - I believe the two components that do not have it fully available is the timepicker and typeahead. I have been bogged down on a major refactor of the datepicker to optionally support moment.js usage.

If you'd like to take a stab at it, feel free to file a PR implementing this - it should be pretty easy to follow the existing feature and tests on some of the other components for adding this to the timepicker.

@icfantv
Copy link
Contributor

icfantv commented Aug 26, 2015

@waratah please let us know if you want to do the PR for this. Otherwise, I can knock this out in an hour or so. Thanks.

@waratah
Copy link
Author

waratah commented Aug 26, 2015

Sorry I am a git newbie. @icfantv can you please.

@icfantv
Copy link
Contributor

icfantv commented Aug 27, 2015

I'll see if I can get to it tonight. I have some work work to do.

@icfantv icfantv self-assigned this Aug 27, 2015
@icfantv icfantv removed the PRs plz! label Aug 27, 2015
icfantv added a commit to icfantv/bootstrap that referenced this issue Aug 27, 2015
* Add support for overriding the `templateUrl` on an instance by instance basis
* Expose controller via `controllerAs`

addresses angular-ui#4275
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants