feat(modal): add container option #4599
Conversation
|
@aroop, I'm a little confused as to what the advantage would be here and what you hope to accomplish. |
|
we used modals and little bit of CSS to build the following components
One of the new requirements that we have for Aside panel is to make it slide from the edge of a DIV. This PR will allow the Aside model to the added to any HTML element in the DOM hierarchy. |
|
Ok. I'll mark it as needs review, but I can't promise anything. |
| }); | ||
|
|
||
| it('should not be added to body if container is passed', function() { | ||
| var subElement = '<div clas="details-panel"></div>'; |
There was a problem hiding this comment.
typo here. should be class.
There was a problem hiding this comment.
Removed usage of class in testcases so that this PR won't give the impression that any element can be found.
| @@ -19,6 +19,7 @@ The `$uibModal` service has only one method: `open(options)` where available opt | |||
| * `windowTemplateUrl` - a path to a template overriding modal's window template | |||
| * `size` - optional suffix of modal window class. The value used is appended to the `modal-` class, i.e. a value of `sm` gives `modal-sm` | |||
| * `openedClass` - class added to the `body` element when the modal is opened. Defaults to `modal-open` | |||
| * `container` - Appends the modal to a specific element. Example: container: 'body'. Defaults to `body` element. | |||
There was a problem hiding this comment.
As we discussed below, please indicate that this must be an angular.element. So the onus is on the user to do the selector.
|
Please clean up the history - there should not be any merge commit. Please use rebase instead. May need to do |
feat(modal): add container option
|
Changing api to be |
|
Hey, |
Allows modal to be added to any element instead of body. If container option is not passed modal will be added to body