Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

bug(carousel): carousel fails to update model changes #488

Closed
srfrnk opened this issue May 31, 2013 · 7 comments
Closed

bug(carousel): carousel fails to update model changes #488

srfrnk opened this issue May 31, 2013 · 7 comments
Labels
component: carousel type: bug
Milestone
0.13.0 (AngularJS...

Comments

@srfrnk
Copy link

srfrnk commented May 31, 2013

Using a carousel with a repeater and an ordeBy filter is great...
Only changes to model are not reflected in the order of the slides.
See fiddle... http://jsfiddle.net/xh4TE/1/
Any way around that?
@mvhecke
Copy link
Contributor

mvhecke commented Jan 8, 2014

@pkozlowski-opensource There's been no reaction in 7 months, I don't think this is relevant anymore.

@srfrnk
Copy link
Author

srfrnk commented Jan 9, 2014

Sad but true...

@srfrnk srfrnk closed this as completed Jan 9, 2014
@chrisirhc
Copy link
Contributor

@srfrnk , do you mean that the carousel doesn't respect the order of slides?

@srfrnk
Copy link
Author

srfrnk commented Jan 9, 2014

What I mean is that on load the carousel does respect the order...
But when changed it doesn't respond....

See plunker:
http://plnkr.co/edit/Hv1vOE76jkTfLhZXoqmQ?p=preview

On start the slides are in order (though the data is setup not in order... proving the orderBy works) but once you change the indexes using the inputs the slider is not reordered while the list underneath is!
Which to me looks like a bug....
Also updated to use latest stable version and it still isn't working.... So should this be reopened or not?

@mvhecke
Copy link
Contributor

mvhecke commented Jan 9, 2014

@srfrnk Yes, because it's still an issue for you.

@srfrnk
Copy link
Author

srfrnk commented Jan 9, 2014

Great.
I don't remember how I worked around the issue back then....
But maybe a fix to this would benefit the community :)

@bekos bekos mentioned this issue Apr 21, 2014
Closed
This was referenced Sep 15, 2014
Closed
Closed
@onemenny
Copy link

any fix with this issue?

kkruit added a commit to kkruit/bootstrap that referenced this issue Nov 11, 2014
@kkruit
fix(carousel): angular-ui#488 Carousel fails to update model changes.
bfa58c0 
 - Uses dom element index.
 - Adds order to indicators to match slide order.
@chrisirhc chrisirhc added this to the Purgatory milestone Nov 11, 2014
@ayakovlevgh ayakovlevgh mentioned this issue Mar 18, 2015
Closed
ayakovlevgh added a commit to ayakovlevgh/bootstrap that referenced this issue Mar 21, 2015
@ayakovlevgh
fix(carousel): respect the order of the slides
ebdbdf1 
index parameter is added to the slide directive. It is used to order the
slides.

Fixes angular-ui#488
@ayakovlevgh ayakovlevgh mentioned this issue Mar 22, 2015
Closed
@karianna karianna removed the PRs plz! label Mar 22, 2015
@karianna karianna modified the milestones: 0.13.0, Purgatory Mar 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: carousel type: bug
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
Development

Successfully merging a pull request may close this issue.

fix(carousel): respect the order of the slides ayakovlevgh/bootstrap
6 participants
@chrisirhc @karianna @pkozlowski-opensource @mvhecke @srfrnk @onemenny