tabs the callback of select function

[watonyweng]

The issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description: when I click the actived tab, the select callback run again

Link to minimally-working plunker that reproduces the issue:

Version of Angular, UIBS, and Bootstrap

Angular: 1.4.4

UIBS: 1.3.1

Bootstrap: 3.3.6

[wesleycho]

Please post a reproduction via Plunker.

[Hsensor]

@wesleycho ; this plunker link http://plnkr.co/edit/TUlFYebCnfs8kqxlVd0P?p=preview;

[watonyweng]

@wesleycho ; this plunker is http://plnkr.co/edit/TUlFYebCnfs8kqxlVd0P?p=preview;

[icfantv]

@1203460788, @watonyweng, please exercise patience. this is an OSS project and we are all unpaid volunteers. we will get to the issue when we are able to make time. duplicate posts and pings are considered rude. thanks.

[wesleycho]

@icfantv your commit hash is broken there.

[wesleycho]

I'm confused with the Plunker - that is exactly what the select callback is for. This doesn't sound like a bug.

Please explain in more detail as per GitHub issue template.

[RobJacobs]

I think the issue is he feels the select callback should not get fired if the tab is already active/selected.

[Hsensor]

@RobJacobs ! you are right. may be my english is poor.

[icfantv]

We've already had a request to ensure it DOES fire even if already selected so this would be a breaking change. I'm nearly certain we pass the $event object so one can very easily check to see if the current tab is already selected and call preventDefault().

I don't have a strong preference as to what solution we go with, but it's far easier to cancel the event than to trigger the select again...