Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Are tabs-left or tabs-right supported in 0.4.0? #581

Closed
brandonhall opened this issue Jun 27, 2013 · 3 comments
Closed

Are tabs-left or tabs-right supported in 0.4.0? #581

brandonhall opened this issue Jun 27, 2013 · 3 comments

Comments

@brandonhall
Copy link

It looks as if there isn't any support for tabs-left or tabs-right classes in the latest version. Am I missing something or was it omitted? Currently, I'm using this as a workaround in my controller. I'm aware it's not an ideal solution for several reasons (e.g., DOM manipulation in a controller, usage of a 0 timeout).

  $timeout(function(){
    angular.element('.tabbable').first().addClass('tabs-left')
  }, 0);
@ghost
Copy link

ghost commented Jun 27, 2013

I miss this feature too.... due to the code it was ommited
For me the possible workaround is to add support for setting class to tabset e.g.

<tabset class="tabs-left">
</tabset>

so that class value would be added to

<div class="tabbable tabs-left">
</div>

@pkozlowski-opensource
Copy link
Member

It was possible to simply add a class prior to 0.4.0 to get the tabs orientation. With the tabs refactoring it is not possible any more. But we've got a ticket opened for this #102

@bk1te @brandonhall feel free to send a pull request for this, it should be a very easy one. Don't forget to add tests!

Closing for now as duplicate of #102

@ghost
Copy link

ghost commented Jun 27, 2013

Ok will send later...
There are simply to lines to change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants