uib-tabset: problems when dynamically adding and removing tabs

[bolemeus]

Bug description:

I have a uib-tabset on my site where there is a fixed first tab, from where I can open additional tabs.
These additional tabs can be closed.
It appears uib-tabset messes up the id's of these new tabs.

The index is set with index = "$index+1", much like the example in the documentation. But it seems that this index is completely ignored, or it is used in some way that I don't understand.
When removing tabs the $index changes, but the active tab index's do not.
Because of this it can happen that you have an active set of tabs with the following index's.

[0, 1, 3, 7, 8]

This would not be such a big deal, but what happens when you add more tabs is more worrying. You'd get the following id's after adding a couple of new tabs.

[0, 1, 3, 7, 8, 5, 6, 7, 8]

You can get duplicate index's this way, resulting in buggy behaviour.

It's probably best to just show the plunkr. See below...

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/RgWAhoZT6F6ORDcqxz6g?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.4.7

UIBS: 1.2.1

Bootstrap: 3.3.1

[wesleycho]

This is because of the lack of use of track by - see here for an example.

[bolemeus]

Hello wesleycho,

It seems the track by doesn't fix the problem.
The example you posted still exhibits thesame problems

[wesleycho]

I was not able to reproduce it - can you give exact reproduction steps?

[eddiriarte]

Hi @wesleycho,
im also still have problems with dynamic tabs

http://plnkr.co/edit/fKrgrC1hA4PmU7d3xuY4?p=preview

[bolemeus]

Hi @wesleycho,
Sorry for the late reply.

It's possible to reproduce the error in the following steps

1. Add a new tab (you now have 3 tabs with the following id's: 0, 1, 2)
2. Remove the second tab (you now have 2 tabs with the following id's: 0, 2; This should be 0, 1)
3. Try to add a new tab. It's impossible because a new tab with id = 2 is trying to be added. You'd get tabs with the following id's: 0, 2, 2.

Additional weird behaviour:
4. Try to add a couple of other new tabs. It won't work.
5. Remove the second tab and all the other new tabs suddenly show up, but some seem to have a duplicate body. This is because some tabs have thesame id.

[bolemeus]

I think this issue has been prematurely closed, and because it is closed I think it will dissapear in the background. Can someone reopen it?

[wesleycho]

Opening so more research can be done - not sure this is a legitimate issue, but I will look into this sometime in the upcoming week.

[bolemeus]

thanks

[mcfdez]

I have the same problem here: http://plnkr.co/edit/02Lll7oPYyvAxcKu5GkK?p=preview

[icfantv]

@wesleycho i think you forgot to reopen this.