Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

bug(demo): hash links don't always work #619

Closed
tobireif opened this issue Jul 4, 2013 · 5 comments
Closed

bug(demo): hash links don't always work #619

tobireif opened this issue Jul 4, 2013 · 5 comments

Comments

@tobireif
Copy link

tobireif commented Jul 4, 2013

When I enter http://angular-ui.github.io/bootstrap/#/pagination , the page doesn't jump to that location on the page.

@tobireif
Copy link
Author

tobireif commented Jul 4, 2013

That's not a duplicate of #620, it's unrelated.

On http://angular-ui.github.io/bootstrap/ , when I select Directives -> Pagination, the page jumps to the Pagination section, and the URL gets set to http://angular-ui.github.io/bootstrap/#/pagination . But if I'd send that URL to someone, and he enters the URL, the page does not jump to the relevant section. I'd have to manually change it to http://angular-ui.github.io/bootstrap/#pagination before sending it (when I remove one slash, the jump happens, at least in FF).

@pkozlowski-opensource
Copy link
Member

@tobireif sorry, you are right.

The issue is that # gets interpreted as an AngularJS route since the demo page is an AngularJS application... Probably changing the $location prexif would fix it.

@tobireif would you mind helping us with this one by investigating it and sending a pull request with a fix? Thank you!

@nakhli
Copy link

nakhli commented Jun 19, 2014

I still have the same issue. when I endter directly the following url: http://angular-ui.github.io/bootstrap/#/modal it gets redirected to http://angular-ui.github.io/bootstrap/modal and fails with a 404

@nakhli
Copy link

nakhli commented Jun 19, 2014

If the demo website is broken it doesn't help the users adopt the library ...

@rvanbaalen
Copy link
Contributor

This issue is fixed in the current demo page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants