This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(rating): plug into ngModel controller
#1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.value = value; | ||
| if ( !$scope.readonly ) { | ||
| ngModelCtrl.$setViewValue(value); | ||
| ngModelCtrl.$render(); |
There was a problem hiding this comment.
Just wondering if this call was necessary as render is called when viewValue differs from modelValue, and during mouseLeave, render is called.
There was a problem hiding this comment.
Are you sure about the $render called by the $setViewValue function?
There was a problem hiding this comment.
Argh, you're right, I'm misreading everything tonight heh. Although it's unlikely that rate() can be called before enter() (mouseenter usually occurs before click). It's safer to have this here.
There was a problem hiding this comment.
No worries, 4-eyes principle :-)
|
I really like this change. 👍 |
BREAKING CHANGE: `rating` is now integrated with `ngModelController`. * `value` is replaced from `ng-model`. Before: <rating value="rate" ...></rating> After: <rating ng-model="rate" ...></rating>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.