This repository has been archived by the owner on May 29, 2019. It is now read-only.
$eval instead of $parse on typeaheadAppendToBody #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using $parse doesn't evaluate the attribute correctly. Changed it to originalScope.$eval.
|
@jbthoma I'm not sure what is the issue you are trying to solve with this pull request. If there is a bug that needs fixing we will need a test that exposes this bug. Could you please add a test or - as a very minimum - a plunker that demonstrates the issue? |
|
Basically the bug I was trying to resolve is if you set typeahead-append-to-body='false', it still appends to the body. I'm not sure how to write the test for it though. |
|
@jbthoma Take a look at the datepicker |
ghost
assigned
|
OK, I can confirm there is a bug in here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using $parse doesn't evaluate the attribute correctly. Changed it to originalScope.$eval.