This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(typeahead): loading callback updates after blur #1904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the input is blurred during an asynchronous call to fetch results, then the results are never shown. However, the loading callback was also never updated to false. This PR fixes this, and updates the loading callback to false when the results of the current view value come in, even if the element doesn't have focus. |
|
@michalc awesome pull request, thnx for this one! All is here: proper fix with minimal changes, test, proper commit message. Great job, going to merge it during the weekend. Thnx once again! |
|
Merged, thnx @michalc ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.