fix(modal): give a reason of rejection when escape key pressed

[tkrotoff]

Make it symmetric with $modalStack.dismiss(modal.key, 'backdrop click')

Fix for #1956

[chrisirhc]

Looks good to me. Although "press" may be more consistent, instead of the past tense.

[tkrotoff]

I would have changed both to past tense:

• 'backdrop clicked'
• 'escape key pressed'

Instead of:

• 'backdrop click'
• 'escape key press'

(sounds better to me, although english is not my mother tongue).

[chrisirhc]

It does sound better logically but I think that putting past tenses in code makes it less accessible to users that aren't very familiar with the English language. The fact that they're also very similar (just two extra letters) makes it easy for users to make mistake.

Since DOM events are always in present tense, I think it's a better idea to keep it similar to DOM events, and use present tense.

With that in mind, it might make sense to keep this consistent with the DOM event that triggered it, so something like: escape keypress or escape keydown.

[bekos]

@tkrotoff Made the change suggested by @chrisirhc and landed. Thx :-)