Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Added an accessibility feature for tabs directive by switching tabs through keyboard #2304

Closed
wants to merge 4 commits into from

Conversation

justin-john
Copy link

As of now, UI module ui.bootstrap.tabs(tabs directive) doesn't have tab switching through keyboard(Tab Key).
This pull request will add an accessibility feature to tabs directive with switching tabs using Tab key of keyboard.

@blah238
Copy link
Contributor

blah238 commented Oct 22, 2014

@justin-john I disagree with selecting (activating) the tab when it gets the focus. That is not how keyboard-accessible tab navigation is supposed to work. If you leave off the ng-focus and just have an empty href, then it works as expected -- you use the tab key to focus a tab, and the enter key to select/activate it.

I have created a separate PR with just the empty href here: #2870

@justin-john
Copy link
Author

@blah238 Ok. Go ahead.

@chrisirhc chrisirhc closed this in 5df524b Nov 3, 2014
@chrisirhc
Copy link
Contributor

Thank you!

OronNadiv pushed a commit to lanetix/bootstrap that referenced this pull request Nov 18, 2014
stevecavanagh pushed a commit to stevecavanagh/bootstrap that referenced this pull request Dec 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants