This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(tooltipProvider): added appendToBody option for $tooltip #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, in re #139 I decided to just create a completely independent option called
appendToBody
for now. Whentrue
, the tooltips will be appended to the body. I do not think this is the best long-term solution, but until someone comes up with something brilliant for containers, this will do.I intentionally did not update the docs. I think before we unleash the
$tooltipProvider
on the public, we should add a few more options to it, some proper defaults, and a few more detailed tests.I also did not update the demo as that is not feasible in this case (needs a
config
block). But all the tests pass and I created a working Plunker.This doesn't close #139 as that's still an issue, but it provides a good stopgap.
What do y'all think?