This repository has been archived by the owner on May 29, 2019. It is now read-only.
Typeahead: move focus to text input with arrow up #2650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to combine the input element in arrow navigation on top of the The tests here are also useful. |
|
Sounds like a good idea. I'll update my pull request with the features from #2916 in the next couple of days |
|
@danemacaulay any update on this? |
|
Closing due to age - feel free to open a new pull request with comments addressed & rebased off of current |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #2597
Input element included in list of results with an activeIdx of -1 and is the default selection on typing. Arrow keys allow full range of navigation from list to input.
I think its good to no longer default to the list and have user explicitly arrow down to list, thoughts?