Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tooltip): memory leak on show/hide #2919

Closed

Conversation

chrisirhc
Copy link
Contributor

Note that this requires #2918 (the first commit in this PR).

Create a new child scope and retain a reference to it so that it can
be destroyed when the tooltip DOM is removed.

Fixes #2709

tt_ scope variables are now in the ttScope which is specific to each
tooltip directive (multiple tooltip directives can now run on the same
element).

This allows tooltips to be used alongside any directive that may or
may not require different scope types.

Closes angular-ui#1269
Fixes angular-ui#2320
Fixes angular-ui#2203
Create a new child scope and retain a reference to it so that it can
be destroyed when the tooltip DOM is removed.

Fixes angular-ui#2709
@chrisirhc chrisirhc added this to the 0.12 milestone Nov 2, 2014
@chrisirhc chrisirhc closed this in faf38d2 Nov 5, 2014
OronNadiv pushed a commit to lanetix/bootstrap that referenced this pull request Nov 18, 2014
Create a new child scope and retain a reference to it so that it can
be destroyed when the tooltip DOM is removed.

Fixes angular-ui#2709
Closes angular-ui#2919
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope leaks on tooltip show/hide
1 participant