Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(demo): Modify the demo app to play nice with Angular 1.3 #3191

Closed
wants to merge 1 commit into from

Conversation

realityking
Copy link
Contributor

This should get the demo app itself working with 1.3 and hopefully makes testing for other issues a bit easier.

Fixes #3098

@mwpowellhtx
Copy link

So the docs said 1.2? Does this mean I can break the champagne and celebrate 1.3 compatibility? Thank you... 👍

@realityking
Copy link
Contributor Author

@mwpowellhtx Unfortunately this is only one of many necessary fixes. This one is only for the demo site, which makes testing with 1.3 a bit easier.

@stevecavanagh
Copy link

This PR is much more concise and understandable than the one I have proposed (PR #3099). Though my PR may seem to make unnecessarily large changes, it merely rearranges the code to move the controller objects out of the global scope. I think it would be best to fix the demo app to follow a best practice and honor the spirit of the intent for throwing the exception (angular/angular.js@3f2232b) and not pollute the global scope. I could certainly add a test to demonstrate that window.MainCtrl, window.DownloadCtrl, and window.SelectModulesCtrl are undefined for my PR.

@realityking
Copy link
Contributor Author

@stevecavanagh Sorry, I hadn't seen your PR (it doesn't have the 1.3 label and I was looking only at those issues) I don't care which one gets merged, I'll leave that up to the maintainers.

@stevecavanagh
Copy link

@realityking No worries, I agree, having either one of these PRs merged would help move 1.3 compatibility forward. It's great to see more maintainers taking a look at these issues.

@wesleycho
Copy link
Contributor

Landed as aa0b639 - thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(demo) MainCtrl function does not load with Angular 1.3
6 participants