fix(datepicker): Check if getter.assign is function fixes #3155 #3345

rvanbaalen · 2015-02-27T13:33:03Z

wesleycho · 2015-03-23T05:45:48Z

src/datepicker/datepicker.js

@@ -490,7 +490,7 @@ function ($compile, $parse, $document, $position, dateFilter, dateParser, datepi
          if ( key === 'datepickerMode' ) {
            var setAttribute = getAttribute.assign;
            scope.$watch('watchData.' + key, function(value, oldvalue) {
-              if ( value !== oldvalue ) {
+              if ( typeof setAttribute === 'function' && value !== oldvalue ) {


Use angular.isFunction

JohannesRudolph · 2015-05-27T16:20:37Z

@rvanbaalen would you be able to update your pull request? Should be trivial to merge then.

JohannesRudolph · 2015-05-27T16:26:47Z

I can confirm this fix works using angular.isFunction

rvanbaalen · 2015-05-27T16:39:13Z

Working on it.

rvanbaalen · 2015-05-27T16:43:43Z

Had to create a new PR since I previously trashed my bootstrap fork. Will merge when Travis is done.

Closes #3155, #3345, #3719

rvanbaalen · 2015-05-28T16:55:50Z

Landed in ed10899

fix(datepicker): Check if getter.assign is function fixes #3155

325bc5d

Closes #3155

karianna added component: datepicker needs: review labels Feb 27, 2015

wesleycho force-pushed the master branch from e373941 to 2c2dba6 Compare March 23, 2015 00:23

wesleycho reviewed Mar 23, 2015
View reviewed changes

wesleycho added needs: work and removed needs: review labels Mar 23, 2015

karianna added this to the 0.13.x milestone Apr 15, 2015

rvanbaalen self-assigned this May 27, 2015

rvanbaalen mentioned this pull request May 27, 2015

fix(datepicker): check if getter.assign is function #3719

Closed

rvanbaalen pushed a commit that referenced this pull request May 28, 2015

fix(datepicker): check if getter.assign is function

ed10899

Closes #3155, #3345, #3719

rvanbaalen closed this May 28, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(datepicker): Check if getter.assign is function fixes #3155 #3345

fix(datepicker): Check if getter.assign is function fixes #3155 #3345

rvanbaalen commented Feb 27, 2015

wesleycho Mar 23, 2015

JohannesRudolph commented May 27, 2015

JohannesRudolph commented May 27, 2015

rvanbaalen commented May 27, 2015

rvanbaalen commented May 27, 2015

rvanbaalen commented May 28, 2015

fix(datepicker): Check if getter.assign is function fixes #3155 #3345

fix(datepicker): Check if getter.assign is function fixes #3155 #3345

Conversation

rvanbaalen commented Feb 27, 2015

wesleycho Mar 23, 2015

Choose a reason for hiding this comment

JohannesRudolph commented May 27, 2015

JohannesRudolph commented May 27, 2015

rvanbaalen commented May 27, 2015

rvanbaalen commented May 27, 2015

rvanbaalen commented May 28, 2015