Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Fix Collapse flickering #3954

Closed
wants to merge 1 commit into from
Closed

Fix Collapse flickering #3954

wants to merge 1 commit into from

Conversation

mseancole
Copy link
Contributor

Only add collapsing class if collapse or in are already attached to element.

Fixes #3801
Plunker

@wesleycho
Copy link
Contributor

Question - does this make #3804 obsolete, or is it still necessary?

If indeed this solves the problem, then I have no problem merging this, as this looks like a better fix.

@wesleycho wesleycho added this to the 0.13.1 (Performance) milestone Jul 16, 2015
@mseancole
Copy link
Contributor Author

@wesleycho This would make it obsolete

@wesleycho
Copy link
Contributor

For posterity, here is a working Plunker with your fix.

@wesleycho
Copy link
Contributor

This has now landed as ede9ea4 - thanks!

@wesleycho wesleycho closed this Jul 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: collapse needs: merging
Projects
None yet
Milestone
0.13.1 (npm)
Development

Successfully merging this pull request may close these issues.
2 participants
@mseancole @wesleycho