This repository has been archived by the owner on May 29, 2019. It is now read-only.
docs(contributing): add link to commit conventions #4161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ StackOverflow is a much better place to ask questions since: | |||
| * questions and answers stay available for public viewing so your question / answer might help someone else | |||
| * SO voting system assures that the best answers are prominently visible. | |||
|
|
|||
| To save your and our time we will be systematically closing all the issues that are request for general support and redirecting people to StackOverflow. | |||
| To save your and our time we will be systematically closing all the issues that are request for general support and redirecting people to StackOverflow. | |||
There was a problem hiding this comment.
What do you think about changing To save your and our time to To save everyone's time?
Please change request to requests.
There was a problem hiding this comment.
I didn't change the text at all - I think my editor just chopped off useless whitespace.
I think the former point, although a little verbose, is a little less harsh than the proposed amendment.
I'll change the request part though.
- Add commit convention link to document
wesleycho
force-pushed
the
docs/contributing
branch
from
36dbd0d
to
b7172a6
Compare
| @@ -9,7 +9,7 @@ StackOverflow is a much better place to ask questions since: | |||
| * questions and answers stay available for public viewing so your question / answer might help someone else | |||
| * SO voting system assures that the best answers are prominently visible. | |||
|
|
|||
| To save your and our time we will be systematically closing all the issues that are request for general support and redirecting people to StackOverflow. | |||
| To save your and our time we will be systematically closing all the issues that are requests for general support and redirecting people to StackOverflow. | |||
There was a problem hiding this comment.
Yea, I was going back and forth on that and was wondering if it would come across as harsh. You just never know what mood someone is going to be in at any given time.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3602.