Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(progress): rename to avoid conflict #4255

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • Rename to ui-progress and ui-bar

This is for fixing #2429, but does not fix it completely. The second step is removing the offending directives, which I have scheduled for 0.14.0 to give consumers of the library adequate time to migrate over.

- Rename to `ui-progress` and `ui-bar`
@wesleycho wesleycho added this to the 0.13.4 (Performance) milestone Aug 21, 2015
@icfantv
Copy link
Contributor

icfantv commented Aug 21, 2015

What do you think about injecting the $log service in the offending directives and adding a warning statement about deprecation?

@wesleycho
Copy link
Contributor Author

Already done if you check it out :P

@icfantv
Copy link
Contributor

icfantv commented Aug 21, 2015

Wow. That was really embarrassing. I told you I was too impulsive...

@icfantv
Copy link
Contributor

icfantv commented Aug 21, 2015

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants