This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(dropdown): restored deprecated directives #4512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better, the if checks for deprecation, move them to the beginning of the link function (as we do in the others). Also, when this gets merged (/me looks to Wes), change fix for chore, we don't need this on changelog. Also, when you inject the config, leave it without prefix for the controller. |
|
Also, there is an old commit in here, I am not sure if that is gonna blow or not. Damn git. |
|
That commit screws up history - this is not mergeable. |
|
I fixed everything in #4514. |
|
Thanks Wes.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.