This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(carousel): add option to prevent pause #509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mokesmokes ! Could you add a unit test for this? |
|
@mokesmokes Could you squash the commits into one and change the commit message to follow the same guidelines as AngularJS? @ajoslin Is there any chance you could review this one? |
sometimes we want the carousel to spin even if the mouse hovers over it. Added an option for an optional attribute, doesn't break current templates
|
Landed in 5f895c1. Also pushed a few other carousel improvements. Thanks @mokesmokes ! |
codedogfish
pushed a commit
to codedogfish/angular-ui-bootstrap
that referenced
this pull request
Sep 15, 2015
angular-ui#289 - Multiple select to not set form to dirty as soon as it load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want the carousel to spin even if the mouse hovers over it. Added an optional attribute, doesn't break current templates.