This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(tab): revert change to linking function #5160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link the issue you are referring to? |
|
Sorry got side lined, the background for this PR is outlined in issue #5161 |
| scope.disabled = !! value; | ||
| }); | ||
| } | ||
| scope.disabled = false; |
There was a problem hiding this comment.
please fix the indents. thanks.
|
Going to close this as stale - in addition, I believe we will have a fix for the original issue when we enforce Angular 1.5+ support at 3.0.0. I believe this PR as is would trigger a breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting commit 2004757 : return to using the compile function rather than the link function. If tab directive using ng=transclude to inject content, the injected html can not refer to injected variables e.g ng-repeat variables. Have raised issue with more detail.