fix(typeahead): Scroll only parent element, not page

[deeg]

Closes #5180

Plunker demonstrating fix

Let me know if you want tests if this is a good solution. I can figure out a way to test it. FWIW does not look like this was being tested before.

[wesleycho]

I'm fine with this approach - @Foxandxss what is your thoughts?

[Foxandxss]

Fine for me, better if tested.

[deeg]

Sounds good, will add tests within an hour or so after I finish some work up.

Hope to make it into 1.0.1 if you don't mind waiting for an hour or two.

[Foxandxss]

That is fine by me.

[deeg]

Just added tests.

Thanks @wesleycho & @Foxandxss for the feedback and getting this into 1.0.1

[frfancha]

The behavior of the last typeahead in the plunker with fix is quite strange: sometimes it opens several pixels under the input instead of just below as usual, and the "candidate" row is not highlighted in blue.
See attached print screen (windows 7, firefox ESR 38.4.0)

[wesleycho]

That is actually a bug that has been existing for about 2-3 years on the demo page, but no fix yet.

[frfancha]

Ok but note that in the plunker without the fix (demo in 5180) I can't reproduce this last problem (at least not after 20 tries) (But I see the bug described in 5180 of course)

[deeg]

I am planning to fix another bug out there while making the behavior a bit better.

I will take a look at the issue you are describing @frfancha and see if I can't fix that also.

@wesleycho, do you know if there is a ticket for that one?

[wesleycho]

The positioning issue with the typeahead demo is the second mentioned in #1988