This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(modal): Open modal is shifting body content to the right on Chrom… #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and Firefox Closes angular-ui#2631
|
There is already a helper function in the |
|
I would like to see all this moved to the $uibPosition service, there is nothing here specific to the modal directive and this could potentially be useful somewhere else. I'll put a PR together... |
|
Closing as I believe a fix is already in a release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e and Firefox
Port of issues fixes twbs/bootstrap#9855 and twbs/bootstrap#15353
I had to move the addClass on body before the animation.
Maybe it would have been better to set the padding on the appendToElement instead of the body ?
Closes #2631