feat(typeahead): added clear button - all in one commit #6189
Conversation
| @@ -162,6 +162,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap | |||
|
|
|||
| //pop-up element used to display matches | |||
| var popUpEl = angular.element('<div uib-typeahead-popup></div>'); | |||
| var clearBtnEl = angular.element('<span class="glyphicon glyphicon-remove" ng-style="{ cursor:\'pointer\',position:\'absolute\',top:positionClearBtn.top+\'px\', left:positionClearBtn.left+\'px\'}" ng-show="showClearBtn" ng-click="clearModel()"></span>'); | |||
There was a problem hiding this comment.
It would be nicer to change this to something similar to how the popUpEl attributes are added (just the line below), i.e.
var clearBtnEl = angular.element('<span></span>');
clearBtnEl.attr({
class: 'glyphicon glyphicon-remove',
style: 'position: absolute; cursor: pointer;',
'ng-style': '...',
...
});
|
Labeling this as a breaking change not because of an actual library breaking change, but one that changes UX. |
|
Hi Wesley. On Sun, Aug 21, 2016 at 5:27 PM, Wesley Cho notifications@github.com
|
No description provided.