Accordion directive: ready to be merged

[pkozlowski-opensource]

So, after some cleanup and tests writing here is the first version of the accordion directive. The usage is very simple:

<accordion>
   <accordion-group title="sth">Static content</accordion-group>
   <accordion-group title="sth">Static content - is it? {{sth}}</accordion-group>
   <accordion-group title="group.title" ng-repeat="group in groups">{{group.content}}</accordion-group>
 </accordion>

Please review and merge.

[pkozlowski-opensource]

Guys, anyone had a chance to look at this PR? I'm going to merge this one if there are no major objections... But I would really love to have your feedback (!)

[ajoslin]

It looks great. I would make the title attribute interpolated {{}} instead, though, as that's the way title is on the tabs directive and the way title normally is (I think all 'normal' html5 attributes should be interpolated)

[pkozlowski-opensource]

Yeh, interpolation would be great. The trouble is that then we are bumping into the issue #5 where @ attributes are messed up while using the templateUrl and transclusion.... This is why I've decided to use = instead and the templateUrl doesn't seem to be interfering with this one... But yes, we should either open a bug to AngularJS guys for this or find some other work-around...

[ajoslin]

Ah right... I guess we should leave it with '=' and change tabs to '=' too...

[dandoyon]

Nice, simple I like this
On Oct 20, 2012, at 2:35 AM, Pawel Kozlowski wrote:

So, after some cleanup and tests writing here is the first version of the accordion directive. The usage is very simple:

Static content Static content - is it? {{sth}} {{group.content}} Please review and merge.

You can merge this Pull Request by running:

git pull https://github.com/angular-ui/bootstrap accordion
Or view, comment on, or merge it at:

#7

Commit Summary

First version of accordion
Accordion directive with tests
File Changes

A src/accordion/accordion.js (66)
A src/accordion/test/accordionSpec.js (145)
A template/accordion/accordion-group.html (8)
A template/accordion/accordion.html (1)
Patch Links

https://github.com/angular-ui/bootstrap/pull/7.patch
https://github.com/angular-ui/bootstrap/pull/7.diff
—
Reply to this email directly or view it on GitHub.