Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

feat(dropdownToggle): Support hover #720

Closed
wants to merge 1 commit into from

Conversation

jusx
Copy link

@jusx jusx commented Jul 27, 2013

Needed this for a project. Simple implementation for hover support.

@ajoslin
Copy link
Contributor

ajoslin commented Jul 27, 2013

Hi @jusx,

Thanks for the PR! you wanted to see something, so you just did it :-)

We're proposing a refactor for dropdown-toggle to make it easier to hookup hover or any event - see #284.

But until the refactor is done, this does work, and I think would be fine to merge. What do you think @angular-ui/bootstrap ?

@ajoslin ajoslin mentioned this pull request Jul 27, 2013
@jusx
Copy link
Author

jusx commented Jul 31, 2013

Hi @ajoslin,

A merge would be awesome! I'll look into the refactor after my tight deadlines. Cheers.

@kencaron
Copy link

Using this as a custom directive in my own project until the merge. Works great.

@mvhecke
Copy link
Contributor

mvhecke commented Oct 13, 2013

I ran tests in the following browsers all on Ubuntu 13.04 accept IE that is on a Win7:

  • Chrome 30.0 - Ok
  • Firefox 24 - Ok
  • IE9 - Ok
  • IE10 - Ok

@mvhecke
Copy link
Contributor

mvhecke commented Oct 14, 2013

@pkozlowski-opensource Pull request passes all tests

@pkozlowski-opensource
Copy link
Member

@jusx I see what you are trying to do but the implementation is very specific to this one particular event (mouseover). I think that we should get it more generic - what if someone wants to open dropdown on focus? We should either use the same logic as in tooltips/popovers or - event better - create an extension point in this directive (in a form of a controller) so other people can plug into the existing infrastructure.

Closing this one for now as I think that the proposed implementation, while does what it is supposed to do, is too specific.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants