This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(pagination): plug into ngModel controller
#999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Both `pagination` and `pager` are now integrated with `ngModelController`. * `page` is replaced from `ng-model`. * `on-select-page` is removed since `ng-change` can now be used. Before: <pagination page="current" on-select-page="changed(page)" ...></pagination> After: <pagination ng-model="$parent.current" ng-change="$parent.changed()" ...></pagination>
|
Oh, @bekos, now I perfectly understand what you've meant by isolated scope + ngModel.... Looking at the examples I'm not sure it is any better after the change... In fact I tend to agree with you that it is probably worse like this :-( I'm really sorry, haven't though about it... I will let you decide what to do with this one but I'm afraid that after the change it might be even more confusing to users... Once again, sorry for not catching this earlier on... |
|
@pkozlowski-opensource Agree and no problem :-) Even though the directive implementation is nicer, the API becomes annoying to use. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.