Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

Scope scrict mode to IIFE #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

gcziprusz
Copy link

Using a file level 'use strict' has the potential to force other libraries into ES5 strict mode and cause issues when minified.

The underlying CodeMirror library will break for example.

this becomes undefined instead of the expected window object:
https://github.com/codemirror/CodeMirror/blob/4bdf6440429bc455f4ce39486d424fba0be7fa14/lib/codemirror.js#L16

@gcziprusz
Copy link
Author

@douglasduteil this strict issue fix should take care of a couple other outstanding PR's like #50 and #39

@magmel48
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants